]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: mc146818: Dont test for bit 0-5 in Register D
authorThomas Gleixner <tglx@linutronix.de>
Mon, 1 Feb 2021 19:24:17 +0000 (20:24 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 2 Feb 2021 19:35:02 +0000 (20:35 +0100)
commit69e1574320a0bfc0e7a986d0596a0f922e3baa2e
tree038aebfe661566d9abe76bf2b20d839e34a820f4
parentec83833613879daa551a14dbd84fd9ed18e6597b
rtc: mc146818: Dont test for bit 0-5 in Register D

The recent change to validate the RTC turned out to be overly tight.

While it cures the problem on the reporters machine it breaks machines
with Intel chipsets which use bit 0-5 of the D register. So check only
for bit 6 being 0 which is the case on these Intel machines as well.

Fixes: ec8383361387 ("rtc: mc146818: Detect and handle broken RTCs")
Reported-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Reported-by: Dirk Gouders <dirk@gouders.net>
Reported-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Dirk Gouders <dirk@gouders.net>
Tested-by: Len Brown <len.brown@intel.com>
Tested-by: Borislav Petkov <bp@suse.de>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/87zh0nbnha.fsf@nanos.tec.linutronix.de
drivers/rtc/rtc-cmos.c
drivers/rtc/rtc-mc146818-lib.c