]> git.baikalelectronics.ru Git - kernel.git/commit
selftests: icmp_redirect: pass xfail=0 to log_test()
authorPo-Hsu Lin <po-hsu.lin@canonical.com>
Fri, 10 Dec 2021 07:25:23 +0000 (15:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 12 Dec 2021 12:56:41 +0000 (12:56 +0000)
commit6955d7e6a43cd694d81a17f4dfc663b8af6a6bb6
treea88d73d7e7087b71ca47596f3cc77999abd71f5d
parent8b536df5bb470482f43b113f0fd427271ebe6e59
selftests: icmp_redirect: pass xfail=0 to log_test()

If any sub-test in this icmp_redirect.sh is failing but not expected
to fail. The script will complain:
    ./icmp_redirect.sh: line 72: [: 1: unary operator expected

This is because when the sub-test is not expected to fail, we won't
pass any value for the xfail local variable in log_test() and thus
it's empty. Fix this by passing 0 as the 4th variable to log_test()
for non-xfail cases.

v2: added fixes tag

Fixes: c6a7c8bd648a ("selftests: icmp_redirect: support expected failures")
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/icmp_redirect.sh