]> git.baikalelectronics.ru Git - kernel.git/commit
tracing: Don't use out-of-sync va_list in event printing
authorNikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Thu, 18 Nov 2021 14:55:16 +0000 (17:55 +0300)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 19 Nov 2021 02:10:18 +0000 (21:10 -0500)
commit6950a1722a4e1ece35c49a1535dc1f30f799e73c
tree4d410a3f4373de3ddd33f137f1f3a8d94609e2c3
parent7ac8730df78a3969d11d35bda27846b597ed5a53
tracing: Don't use out-of-sync va_list in event printing

If trace_seq becomes full, trace_seq_vprintf() no longer consumes
arguments from va_list, making va_list out of sync with format
processing by trace_check_vprintf().

This causes va_arg() in trace_check_vprintf() to return wrong
positional argument, which results into a WARN_ON_ONCE() hit.

ftrace_stress_test from LTP triggers this situation.

Fix it by explicitly avoiding further use if va_list at the point
when it's consistency can no longer be guaranteed.

Link: https://lkml.kernel.org/r/20211118145516.13219-1-nikita.yushchenko@virtuozzo.com
Signed-off-by: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace.c