]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: allow readdir()'s of large empty directories to be interrupted
authorTheodore Ts'o <tytso@mit.edu>
Sun, 24 Apr 2016 02:50:07 +0000 (22:50 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 24 Apr 2016 02:50:07 +0000 (22:50 -0400)
commit690f5bb4151a099c81cfceb190beb9898c62f283
tree4e41c7a0fd5204cad9e651baa23207bf4dafe256
parent29117ef53592e44617a5e92e9234f15273b7ba82
ext4: allow readdir()'s of large empty directories to be interrupted

If a directory has a large number of empty blocks, iterating over all
of them can take a long time, leading to scheduler warnings and users
getting irritated when they can't kill a process in the middle of one
of these long-running readdir operations.  Fix this by adding checks to
ext4_readdir() and ext4_htree_fill_tree().

This was reverted earlier due to a typo in the original commit where I
experimented with using signal_pending() instead of
fatal_signal_pending().  The test was in the wrong place if we were
going to return signal_pending() since we would end up returning
duplicant entries.  See 67f586c73f01 for a more detailed explanation.

Added fix as suggested by Linus to check for signal_pending() in
in the filldir() functions.

Reported-by: Benjamin LaHaise <bcrl@kvack.org>
Google-Bug-Id: 27880676
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/compat.c
fs/ext4/dir.c
fs/ext4/namei.c
fs/readdir.c