]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "usb: dwc3: meson-g12a: fix shared reset control use"
authorAmjad Ouled-Ameur <aouledameur@baylibre.com>
Thu, 27 Aug 2020 14:48:10 +0000 (16:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Sep 2020 14:41:22 +0000 (16:41 +0200)
commit67fab15bc32e74712e558d256b71b7fe42b9475b
tree6dd2e943e87d058cd889c0aefa2175d282a14d77
parent5762db20a3809835475ba1c009077a651ea4f442
Revert "usb: dwc3: meson-g12a: fix shared reset control use"

This reverts commit e9a27693bfd29fd4d8b0f79c97343d6f4e04e0f8.

This commit breaks USB on meson-gxl-s905x-libretech-cc. Reverting
the change solves the issue.

In fact, according to the reset framework code, consumers must not use
reset_control_(de)assert() on shared reset lines when reset_control_reset
has been used, and vice-versa.

Moreover, with this commit, usb is not guaranted to be reset since the
reset is likely to be initially deasserted.

Reverting the commit will bring back the suspend warning mentioned in the
commit description. Nevertheless, a warning is much less critical than
breaking dwc3-meson-g12a USB completely. We will address the warning
issue in another way as a 2nd step.

Fixes: e9a27693bfd2 ("usb: dwc3: meson-g12a: fix shared reset control use")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Reported-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20200827144810.26657-1-aouledameur@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-meson-g12a.c