]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/net/bonding: Adjust constant name
authorJulia Lawall <julia@diku.dk>
Sat, 11 Jul 2009 10:03:55 +0000 (10:03 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Jul 2009 03:11:32 +0000 (20:11 -0700)
commit67cd89695abeb0301c7c361fdc95574dcc54146b
tree4088f80a6ea48205a5d19251d5ee4c8aa29f3ac6
parented50eada67763a4911634ca806ab04ef53f09de6
drivers/net/bonding: Adjust constant name

AD_SHORT_TIMEOUT and AD_STATE_LACP_ACTIVITY have the same value, but
AD_STATE_LACP_ACTIVITY better reflects the intended semantics.

[ J adds: AD_STATE_LACP_ACTIVITY is a value defined by the standard, and
should be set here in accordance with 802.3ad 43.4.12; AD_SHORT_TIMEOUT
is a constant specific to the Linux 802.3ad implementation that happens
to have the same value ]

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
struct port_params p;
@@
* p.port_state |= AD_SHORT_TIMEOUT
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_3ad.c