]> git.baikalelectronics.ru Git - kernel.git/commit
uprobes/x86: Send SIGILL if arch_uprobe_post_xol() fails
authorOleg Nesterov <oleg@redhat.com>
Thu, 3 Apr 2014 18:20:10 +0000 (20:20 +0200)
committerOleg Nesterov <oleg@redhat.com>
Thu, 17 Apr 2014 19:58:20 +0000 (21:58 +0200)
commit67a321293c08881aaf8efc65d60acbf63fe2d7a6
treecbefdeb0f0d2b84f7609313f28fdf460c42dfaac
parent12855046b88d010c2bcb7d12b2de2bf2eb709c9f
uprobes/x86: Send SIGILL if arch_uprobe_post_xol() fails

Currently the error from arch_uprobe_post_xol() is silently ignored.
This doesn't look good and this can lead to the hard-to-debug problems.

1. Change handle_singlestep() to loudly complain and send SIGILL.

   Note: this only affects x86, ppc/arm can't fail.

2. Change arch_uprobe_post_xol() to call arch_uprobe_abort_xol() and
   avoid TF games if it is going to return an error.

   This can help to to analyze the problem, if nothing else we should
   not report ->ip = xol_slot in the core-file.

   Note: this means that handle_riprel_post_xol() can be called twice,
   but this is fine because it is idempotent.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Reviewed-by: Jim Keniston <jkenisto@us.ibm.com>
arch/x86/kernel/uprobes.c
kernel/events/uprobes.c