]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bba1607) | patch
iio: light: si1133 fix test for val being not zero or not one.
authorColin Ian King <colin.king@canonical.com>
Mon, 30 Jul 2018 12:59:18 +0000 (13:59 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 30 Jul 2018 18:28:47 +0000 (19:28 +0100)
commit67956c3c0732cb969b1e38af18e567a987d0792e
tree8a709016982e48dffcb072412e835311cedfa4aftree | snapshot
parentbba160735038fef0c65c246ce32816f5e2b2e4bfcommit | diff
iio: light: si1133 fix test for val being not zero or not one.

The current check on val always results in true and so the
call to sii1133_update_adcsens never gets called. Fix this check
so it returns with -EINVAL only when val is not zero and not one.

Detected by CoverityScan, CID#1472099 ("Logically dead code")

Fixes: 13e7dabc4c37 ("iio: light: introduce si1133")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/si1133.c diff | blob | history
Linux Kernel Source Tree.