]> git.baikalelectronics.ru Git - kernel.git/commit
spi: dw: Fix spi registration for controllers overriding CS
authorLars Povlsen <lars.povlsen@microchip.com>
Fri, 20 Nov 2020 21:34:14 +0000 (22:34 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 25 Nov 2020 12:54:05 +0000 (12:54 +0000)
commit677965183db58cdf195823a2011a1236909a66c1
tree47f3d5af55c6df93a0b24334c1bcf929095935b1
parent44934a6e12cba9a3c405ce02b80928a92ebf36ed
spi: dw: Fix spi registration for controllers overriding CS

When SPI DW memory ops support was introduced, there was a check for
excluding controllers which supplied their own CS function. Even so,
the mem_ops pointer is *always* presented to the SPI core.

This causes the SPI core sanity check in spi_controller_check_ops() to
refuse registration, since a mem_ops pointer is being supplied without
an exec_op member function.

The end result is failure of the SPI DW driver on sparx5 and similar
platforms.

The fix in the core SPI DW driver is to avoid presenting the mem_ops
pointer if the exec_op function is not set.

Fixes: 7c1c11540afd (spi: dw: Add memory operations support)
Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/20201120213414.339701-1-lars.povlsen@microchip.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw-core.c