]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ARM: imx: add FEC sleep mode callback function"
authorFabio Estevam <fabio.estevam@freescale.com>
Wed, 7 Jan 2015 12:39:52 +0000 (10:39 -0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Jan 2015 04:05:19 +0000 (20:05 -0800)
commit673356b2edd890896c9b43c97df3b7dca97cd683
tree1d109731d6d603c892abdf34a6f16836d51c7c65
parentb60a416b7ed9e13881aa64d700cba8657944cd37
Revert "ARM: imx: add FEC sleep mode callback function"

i.MX platform maintainer Shawn Guo is not happy with the such commit as
explained below [1]:

"The GPR difference between SoCs can be encoded in device tree as well.
It's pointless to repeat the same code pattern for every single
platform, that need to set up GPR bits for enabling magic packet wake
up, while the only difference is the register and bit offset.

The platform code will become quite messy and unmaintainable if every
device driver dump their GPR register setup code into platform.

Sorry, but it's NACK from me."

This reverts commit 2e93fc9ba7df38c ("ARM: imx: add FEC sleep mode callback
function").

[1] http://www.spinics.net/lists/netdev/msg310922.html

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/arm/mach-imx/mach-imx6q.c
arch/arm/mach-imx/mach-imx6sx.c