]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Don't dereference request if it may have been retired when printing
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 18 Jun 2019 16:19:51 +0000 (17:19 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 18 Jun 2019 17:14:43 +0000 (18:14 +0100)
commit66fb3bc36a66352686182afd9e457c940a31adef
tree2419428db7c5390302d05648ad8b92e60e2a8032
parent61452b8849e68a2c8fd362c07a07d2f688a2fc85
drm/i915: Don't dereference request if it may have been retired when printing

This has caught me out on countless occasions, when we retrieve a pointer
from the submission/execlists backend, it does not carry a reference to
the context or ring. Those are only pinned while the request is active,
so if we see the request is already completed, it may be in the process
of being retired and those pointers defunct.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110938
Fixes: fc2d9352bf84 ("drm/i915: Show ring->start for the ELSP context/request queue")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190618161951.28820-2-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_engine_cs.c