]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc: Fix deadlock with multiple calls to smp_send_stop
authorNicholas Piggin <npiggin@gmail.com>
Fri, 27 Apr 2018 01:51:59 +0000 (11:51 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 27 Apr 2018 06:35:57 +0000 (16:35 +1000)
commit66a00f546b661f4d040073506dd1e00093393f57
tree912e2106089759f15a24f1e2f5bf384946c42878
parent1d694106a62ee34c45757b1089180f2ac3926414
powerpc: Fix deadlock with multiple calls to smp_send_stop

smp_send_stop can lock up the IPI path for any subsequent calls,
because the receiving CPUs spin in their handler function. This
started becoming a problem with the addition of an smp_send_stop
call in the reboot path, because panics can reboot after doing
their own smp_send_stop.

The NMI IPI variant was fixed with 2ac0c1b95f ("powerpc: Fix
smp_send_stop NMI IPI handling"), which leaves the smp_call_function
variant.

This is fixed by having smp_send_stop only ever do the
smp_call_function once. This is a bit less robust than the NMI IPI
fix, because any other call to smp_call_function after smp_send_stop
could deadlock, but that has always been the case, and it was not
been a problem before.

Fixes: 6c44e900c60b2 ("powerpc/powernv: Always stop secondaries before reboot/shutdown")
Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/smp.c