]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: fix hda AZX_DCAPS_NO_TCSEL quirk check in driver_caps
authorLinus Torvalds <torvalds@linux-foundation.org>
Sat, 28 May 2011 02:45:28 +0000 (19:45 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 28 May 2011 02:45:28 +0000 (19:45 -0700)
commit668c3596f91abd892245dd26ff2a9a13a34b4c0d
treed9fba88eb0157e3413eecc79b2fe354974a1ad97
parent43bbf725af38fd2ff5ba8e4d073e890b9415bb2f
ALSA: fix hda AZX_DCAPS_NO_TCSEL quirk check in driver_caps

Commit 595094ff4691 ("ALSA: hda - Reorganize controller quriks with bit
flags") changed the driver type compares into various quirk bits.
However, the check for AZX_DCAPS_NO_TCSEL got reverted: instead of
clearing TCSEL for chipsets that have that standard capability, it
cleared then when the NO_TCSEL bit was set.

This can lead to noise and repeated sounds - a weird "echo" behavior.
As the comment just above says: "Ensuring these bits are 0 clears
playback static on some HD Audio codecs".  Which is definitely true at
least on my Core i5 Westmere system.

Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
sound/pci/hda/hda_intel.c