]> git.baikalelectronics.ru Git - kernel.git/commit
crypto: crc32c - Fix crc32c soft dependency
authorJean Delvare <jdelvare@suse.de>
Mon, 18 Jan 2016 16:06:05 +0000 (17:06 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 19 Jan 2016 07:52:10 +0000 (15:52 +0800)
commit66796d8dee4706563f99f50099501c0533a08fd2
tree96e33af1bc3caf9690fee29ed3331a88a90272c5
parentcdb32bf4d9ede9cad3d8e025690f644852663b94
crypto: crc32c - Fix crc32c soft dependency

I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Cc: stable@vger.kernel.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/crc32c_generic.c
lib/libcrc32c.c