]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: txp: Don't set TXP_VSTART_AT_EOF
authorMaxime Ripard <maxime@cerno.tech>
Mon, 28 Mar 2022 15:36:55 +0000 (17:36 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 8 Apr 2022 11:38:06 +0000 (13:38 +0200)
commit6653405ee7ac6bc5ee8115d1b56b4733dd11e011
tree694a556bfc715114a9a75e3a65fdfe6ce4415033
parentf8953c9b6ce54fbd9f08b70941fcd8c6a96275a5
drm/vc4: txp: Don't set TXP_VSTART_AT_EOF

The TXP_VSTART_AT_EOF will generate a second VSTART signal to the HVS.
However, the HVS waits for VSTART to enable the FIFO and will thus start
filling the FIFO before the start of the frame.

This leads to corruption at the beginning of the first frame, and
content from the previous frame at the beginning of the next frames.

Since one VSTART is enough, let's get rid of it.

Fixes: 2040cc595849 ("drm/vc4: Add support for the transposer block")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-3-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_txp.c