]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in new_tape_buffer
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 10 Apr 2018 12:38:42 +0000 (20:38 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 Apr 2018 23:14:37 +0000 (19:14 -0400)
commit662373f6bcc4c0190a717a4974b3072a15758fab
treea06849376cd9c87197b1277592398eff2f0add31
parent24a45f60122daab18552fcf334a2048aac8d46a9
scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in new_tape_buffer

new_tape_buffer() is never called in atomic context. new_tape_buffer()
is only called by st_probe(), which is only set as ".probe" in struct
scsi_driver.

Despite never getting called from atomic context, new_tape_buffer()
calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which
can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/st.c