]> git.baikalelectronics.ru Git - kernel.git/commit
selftests/bpf: Preserve errno in test_progs CHECK macros
authorAndrey Ignatov <rdna@fb.com>
Fri, 20 Dec 2019 00:05:11 +0000 (16:05 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 21 Dec 2019 00:06:02 +0000 (16:06 -0800)
commit661b7d89bf7a87f0e915306c11dfb227972c5450
tree537e46aa39c0c2fe37da471dd970177c513051d8
parent5dba60bbce3fe81937d28a265b21f50bc105c576
selftests/bpf: Preserve errno in test_progs CHECK macros

It's follow-up for discussion [1]

CHECK and CHECK_FAIL macros in test_progs.h can affect errno in some
circumstances, e.g. if some code accidentally closes stdout. It makes
checking errno in patterns like this unreliable:

if (CHECK(!bpf_prog_attach_xattr(...), "tag", "msg"))
goto err;
CHECK_FAIL(errno != ENOENT);

, since by CHECK_FAIL time errno could be affected not only by
bpf_prog_attach_xattr but by CHECK as well.

Fix it by saving and restoring errno in the macros. There is no "Fixes"
tag since no problems were discovered yet and it's rather precaution.

test_progs was run with this change and no difference was identified.

[1] https://lore.kernel.org/bpf/20191219210907.GD16266@rdna-mbp.dhcp.thefacebook.com/

Signed-off-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20191220000511.1684853-1-rdna@fb.com
tools/testing/selftests/bpf/test_progs.h