]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 04dc621) | patch
ksz884x: don't copy too much in netdev_set_mac_address()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 19 Apr 2012 07:00:19 +0000 (10:00 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Apr 2012 17:25:03 +0000 (13:25 -0400)
commit65df46de77b61a805ba7b362608d0903373ff954
treed0e70526f6b98daa8ec61ad06d72a666392d1ad0tree | snapshot
parent04dc62124f686c8e02b8502ea95cdcc9ed83f7eccommit | diff
ksz884x: don't copy too much in netdev_set_mac_address()

MAX_ADDR_LEN is 32.  ETH_ALEN is 6.  mac->sa_data is a 14 byte array, so
the memcpy() is doing a read past the end of the array.  I asked about
this on netdev and Ben Hutchings told me it's supposed to be copying
ETH_ALEN bytes (thanks Ben).

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/micrel/ksz884x.c diff | blob | history
Linux Kernel Source Tree.