]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock
authorImre Deak <imre.deak@intel.com>
Mon, 29 Jun 2020 18:58:47 +0000 (21:58 +0300)
committerImre Deak <imre.deak@intel.com>
Wed, 1 Jul 2020 12:39:00 +0000 (15:39 +0300)
commit65953e20064adf3e9940144b26a3cab4e2427ee0
tree81156a180c4e470616e86e6816b0fa4944457494
parentb7517f6b816473cb456e6c8dc518262c4bb80941
drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock

When the reference clock is 38.4MHz, using the current TBT PLL
fractional divider value results in a slightly off TBT link frequency.
This causes an endless loop of link training success followed by a bad
link signaling and retraining at least on a Dell WD19TB TBT dock.  The
workaround provided by the HW team is to divide the fractional divider
value by two. This fixed the link training problem on the ThinkPad dock.

The same workaround is needed on some EHL platforms and for combo PHY
PLLs, these will be addressed in a follow-up.

Bspec: 49204

References: HSDES#22010772725
References: HSDES#14011861142
Reported-and-tested-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200629185848.20550-1-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_dpll_mgr.c