]> git.baikalelectronics.ru Git - kernel.git/commit
stmmac: intel: Fix kernel crash due to wrong error path
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 29 Apr 2020 15:09:32 +0000 (18:09 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 May 2020 04:00:17 +0000 (21:00 -0700)
commit6503327091c02041195da94886a146ec5ba0735f
treefe5c2c4eecc3874e50090d91cef04d81e33681fd
parent261b8459979fd3d9f9435d2a3fdff8192ee6fea4
stmmac: intel: Fix kernel crash due to wrong error path

Unfortunately sometimes ->probe() may fail. The commit 4b6385a9c599
("net: stmmac: Enable SERDES power up/down sequence")
messed up with error handling and thus:

[   12.811311] ------------[ cut here ]------------
[   12.811993] kernel BUG at net/core/dev.c:9937!

Fix this by properly crafted error path.

Fixes: 4b6385a9c599 ("net: stmmac: Enable SERDES power up/down sequence")
Cc: Voon Weifeng <weifeng.voon@intel.com>
Cc: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c