]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: brcmstb: Use reset/rearm instead of deassert/assert
authorJim Quinlan <jim2101024@gmail.com>
Fri, 30 Apr 2021 15:21:56 +0000 (11:21 -0400)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 3 May 2021 18:16:28 +0000 (13:16 -0500)
commit6426d31ccf9b73360e3cd621397c29bdadef9a54
treecab490fe6471176bdd89afeef31bc5ba9291ca25
parentbc03fc4fff884ac98dee0558f80acf2ac743ce7c
PCI: brcmstb: Use reset/rearm instead of deassert/assert

The Broadcom STB PCIe RC uses a reset control "rescal" for certain chips.
The "rescal" implements a "pulse reset" so using assert/deassert is wrong
for this device.  Instead, we use reset/rearm.  We need to use rearm so
that we can reset it after a suspend/resume cycle; w/o using "rearm", the
"rescal" device will only ever fire once.

Of course for suspend/resume to work we also need to put the reset/rearm
calls in the suspend and resume routines.

Fixes: 9bc89cdb54ab ("PCI: brcmstb: Add control of rescal reset")
Link: https://lore.kernel.org/r/20210430152156.21162-4-jim2101024@gmail.com
Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
drivers/pci/controller/pcie-brcmstb.c