]> git.baikalelectronics.ru Git - kernel.git/commit
udmabuf: fix general protection fault in udmabuf_create
authorPavel Skripkin <paskripkin@gmail.com>
Wed, 11 Aug 2021 17:50:52 +0000 (20:50 +0300)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 12 Aug 2021 07:27:22 +0000 (09:27 +0200)
commit64215c0843277335b2025bbb9b36acf66966be5b
tree37c0c51100ab841911453d60f4531a75b96c150f
parent7bc48082b64f1ebe3f68c8c4cd6f5e9625741304
udmabuf: fix general protection fault in udmabuf_create

Syzbot reported general protection fault in udmabuf_create. The problem
was in wrong error handling.

In commit f6974c7db627 ("udmabuf: Add support for mapping hugepages (v4)")
shmem_read_mapping_page() call was replaced with find_get_page_flags(),
but find_get_page_flags() returns NULL on failure instead PTR_ERR().

Wrong error checking was causing GPF in get_page(), since passed page
was equal to NULL. Fix it by changing if (IS_ER(!hpage)) to if (!hpage)

Reported-by: syzbot+e9cd3122a37c5d6c51e8@syzkaller.appspotmail.com
Fixes: f6974c7db627 ("udmabuf: Add support for mapping hugepages (v4)")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210811175052.21254-1-paskripkin@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/dma-buf/udmabuf.c