]> git.baikalelectronics.ru Git - kernel.git/commit
drm/msm/gpu: Fix potential double-free
authorRob Clark <robdclark@chromium.org>
Tue, 10 Jan 2023 21:28:59 +0000 (13:28 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:09 +0000 (08:34 +0100)
commit63d04557b7cb559e5e0488877fc6df09876e2d89
tree1d1fa6a12fcf3722a31a446e4275bbee5b2042b8
parent82b9890e52be7569c1391a68c3058c00b4fd7a67
drm/msm/gpu: Fix potential double-free

[ Upstream commit 88bdf7ecabe5f3d98c89b605740a22bfbd333929 ]

If userspace was calling the MSM_SET_PARAM ioctl on multiple threads to
set the COMM or CMDLINE param, it could trigger a race causing the
previous value to be kfree'd multiple times.  Fix this by serializing on
the gpu lock.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Fixes: c4038750b1a2 ("drm/msm: Add a way to override processes comm/cmdline")
Patchwork: https://patchwork.freedesktop.org/patch/517778/
Link: https://lore.kernel.org/r/20230110212903.1925878-1-robdclark@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/adreno/adreno_gpu.c
drivers/gpu/drm/msm/msm_gpu.c
drivers/gpu/drm/msm/msm_gpu.h