]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: txp: Force alpha to be 0xff if it's disabled
authorMaxime Ripard <maxime@cerno.tech>
Mon, 28 Mar 2022 15:36:56 +0000 (17:36 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 8 Apr 2022 11:38:06 +0000 (13:38 +0200)
commit6398eda9fb53a40177daf072ca71e01bf6702594
tree5a1903e4bd14b3465f1d9bf3fad403663ea1d71f
parentf9bdb99aa5e83005c29dd1a54ac0d609907da68c
drm/vc4: txp: Force alpha to be 0xff if it's disabled

If we use a format that has padding instead of the alpha component (such
as XRGB8888), it appears that the Transposer will fill the padding to 0,
disregarding what was stored in the input buffer padding.

This leads to issues with IGT, since it will set the padding to 0xff,
but will then compare the CRC of the two frames which will thus fail.
Another nice side effect is that it is now possible to just use the
buffer as ARGB.

Fixes: 1cb665b20cfe ("drm/vc4: Add support for the transposer block")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-4-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_txp.c