]> git.baikalelectronics.ru Git - kernel.git/commit
net: pktgen: don't abuse current->state in pktgen_thread_worker()
authorOleg Nesterov <oleg@redhat.com>
Tue, 4 Aug 2015 16:33:34 +0000 (18:33 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Aug 2015 06:52:44 +0000 (23:52 -0700)
commit62ff0ca40b33edc782b0cd6c1a84ccf019485d24
tree042783b9d9b3458790c4c914e9a219e9ac69c175
parent68af93987c149f3604b6ab78651fba6b47d038cb
net: pktgen: don't abuse current->state in pktgen_thread_worker()

Commit 967c481ef8a7 "net: pktgen: kill the Wait for kthread_stop
code in pktgen_thread_worker()" removed (in particular) the final
__set_current_state(TASK_RUNNING) and I didn't notice the previous
set_current_state(TASK_INTERRUPTIBLE). This triggers the warning
in __might_sleep() after return.

Afaics, we can simply remove both set_current_state()'s, and we
could do this a long ago right after 6b43ee8f62102 "pktgen: better
scheduler friendliness" which changed pktgen_thread_worker() to
use wait_event_interruptible_timeout().

Reported-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/pktgen.c