]> git.baikalelectronics.ru Git - kernel.git/commit
nfsd4: downgrade some fs/nfsd/nfs4state.c BUG's
authorJ. Bruce Fields <bfields@redhat.com>
Sun, 25 Nov 2012 19:48:10 +0000 (14:48 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 26 Nov 2012 14:08:16 +0000 (09:08 -0500)
commit626dc06e6234621ca0660fb44bb661fffb013b9d
treed67d23112e25ae14f5c3be1b67db71d8fa45af79
parent6a4ee61734386c355336c26afa3dd7e5fef224b0
nfsd4: downgrade some fs/nfsd/nfs4state.c BUG's

Linus has pointed out that indiscriminate use of BUG's can make it
harder to diagnose bugs because they can bring a machine down, often
before we manage to get any useful debugging information to the logs.
(Consider, for example, a BUG() that fires in a workqueue, or while
holding a spinlock).

Most of these BUG's won't do much more than kill an nfsd thread, but it
would still probably be safer to get out the warning without dying.

There's still more of this to do in nfsd/.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c