]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "scsi: libfc: Add WARN_ON() when deleting rports"
authorRoss Lagerwall <ross.lagerwall@citrix.com>
Fri, 1 Feb 2019 14:42:28 +0000 (14:42 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 5 Feb 2019 03:17:33 +0000 (22:17 -0500)
commit61cdbbae83963e2b7a4f1f0030445c8190fc8f81
treee0841d9b235da0965232505460e47fbb94f75605
parenta6a611b1dc58ee90f771341f750f0cfa77e85667
Revert "scsi: libfc: Add WARN_ON() when deleting rports"

This reverts commit c413619c95c387e64c406dbc2fd9bdfe6a2e6b7f.

It added a warning whose intent was to check whether the rport was still
linked into the peer list. It doesn't work as intended and gives false
positive warnings for two reasons:

1) If the rport is never linked into the peer list it will not be
considered empty since the list_head is never initialized.

2) If the rport is deleted from the peer list using list_del_rcu(), then
the list_head is in an undefined state and it is not considered empty.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libfc/fc_rport.c