]> git.baikalelectronics.ru Git - kernel.git/commit
clk: actions: Fix factor clk struct member access
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Mon, 16 Sep 2019 15:45:40 +0000 (21:15 +0530)
committerStephen Boyd <sboyd@kernel.org>
Tue, 17 Sep 2019 19:54:44 +0000 (12:54 -0700)
commit60785bb926f04fce795c6336e68d80e4ec25072f
tree7d1ad1652a7d922e0f25b1b6555d741127c0e5e7
parent8ae2f793d21f67d4ab95029bb6873efffa36907b
clk: actions: Fix factor clk struct member access

Since the helper "owl_factor_helper_round_rate" is shared between factor
and composite clocks, using the factor clk specific helper function
like "hw_to_owl_factor" to access its members will create issues when
called from composite clk specific code. Hence, pass the "factor_hw"
struct pointer directly instead of fetching it using factor clk specific
helpers.

This issue has been observed when a composite clock like "sd0_clk" tried
to call "owl_factor_helper_round_rate" resulting in pointer dereferencing
error.

While we are at it, let's rename the "clk_val_best" function to
"owl_clk_val_best" since this is an owl SoCs specific helper.

Fixes: f30bb28c5da3 ("clk: actions: Add factor clock support")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20190916154546.24982-2-manivannan.sadhasivam@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/actions/owl-factor.c