]> git.baikalelectronics.ru Git - kernel.git/commit
nvme/pci: move cqe check after device shutdown
authorKeith Busch <kbusch@kernel.org>
Wed, 12 Feb 2020 16:41:05 +0000 (01:41 +0900)
committerJens Axboe <axboe@kernel.dk>
Fri, 14 Feb 2020 17:12:04 +0000 (10:12 -0700)
commit60266beac2226a8332e9191b2168d21f86a3ee48
tree92f1ef119f86b134f7ea6da287d1b75fa5e5948c
parent2f3032b433e7141a6ddf284181f8f635a94e4ba5
nvme/pci: move cqe check after device shutdown

Many users have reported nvme triggered irq_startup() warnings during
shutdown. The driver uses the nvme queue's irq to synchronize scanning
for completions, and enabling an interrupt affined to only offline CPUs
triggers the alarming warning.

Move the final CQE check to after disabling the device and all
registered interrupts have been torn down so that we do not have any
IRQ to synchronize.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=206509
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/pci.c