]> git.baikalelectronics.ru Git - kernel.git/commit
net: bgmac: Drop free_netdev() from bgmac_enet_remove()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 9 Nov 2022 15:01:36 +0000 (15:01 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Nov 2022 16:42:15 +0000 (17:42 +0100)
commit601dcae9fd7c0a502bf31034d403d24d349f731b
treef39e634ee006e34c4d2252209e6c6a824994c080
parent9d460b7a860df541b0b3f2852eeb30db863fe5f6
net: bgmac: Drop free_netdev() from bgmac_enet_remove()

[ Upstream commit 8096497c1ee6a5b615ae34307405d2295a55b389 ]

netdev is allocated in bgmac_alloc() with devm_alloc_etherdev() and will
be auto released in ->remove and ->probe failure path. Using free_netdev()
in bgmac_enet_remove() leads to double free.

Fixes: 1a32f7d0962e ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221109150136.2991171-1-weiyongjun@huaweicloud.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bgmac.c