]> git.baikalelectronics.ru Git - kernel.git/commit
net: sparx5: Do not use mac_addr uninitialized in mchp_sparx5_probe()
authorNathan Chancellor <nathan@kernel.org>
Sun, 27 Jun 2021 18:45:43 +0000 (11:45 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jun 2021 22:50:21 +0000 (15:50 -0700)
commit5ff59f6f107060147d32eb6d10c70ea012b1457a
treed8597b8f7e0ce4274eb49bb39b0eb45c82c9fdb4
parent8103e343c5d43b82103cdd9a15a7e6db24398401
net: sparx5: Do not use mac_addr uninitialized in mchp_sparx5_probe()

Clang warns:

drivers/net/ethernet/microchip/sparx5/sparx5_main.c:760:29: warning:
variable 'mac_addr' is uninitialized when used here [-Wuninitialized]
        if (of_get_mac_address(np, mac_addr)) {
                                   ^~~~~~~~
drivers/net/ethernet/microchip/sparx5/sparx5_main.c:669:14: note:
initialize the variable 'mac_addr' to silence this warning
        u8 *mac_addr;
                    ^
                     = NULL
1 warning generated.

mac_addr is only used to store the value retrieved from
of_get_mac_address(), which is then copied into the base_mac member of
the sparx5 struct using ether_addr_copy(). It is easier to just use the
base_mac address directly, which avoids the warning and the extra copy.

Fixes: 96594a6222c1 ("net: sparx5: add the basic sparx5 driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1413
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/sparx5/sparx5_main.c