]> git.baikalelectronics.ru Git - kernel.git/commit
NFSD: Protect against send buffer overflow in NFSv3 READ
authorChuck Lever <chuck.lever@oracle.com>
Thu, 1 Sep 2022 19:10:24 +0000 (15:10 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 26 Sep 2022 18:02:30 +0000 (14:02 -0400)
commit5fd403115bf6c3fd383e7e020f51f21b96e4d18b
tree93d3a0582f62f3f449711a64c13c7202b5874317
parent5745ba8c1d0a4ac2b75df54a7fcf1faae0a537de
NFSD: Protect against send buffer overflow in NFSv3 READ

Since before the git era, NFSD has conserved the number of pages
held by each nfsd thread by combining the RPC receive and send
buffers into a single array of pages. This works because there are
no cases where an operation needs a large RPC Call message and a
large RPC Reply at the same time.

Once an RPC Call has been received, svc_process() updates
svc_rqst::rq_res to describe the part of rq_pages that can be
used for constructing the Reply. This means that the send buffer
(rq_res) shrinks when the received RPC record containing the RPC
Call is large.

A client can force this shrinkage on TCP by sending a correctly-
formed RPC Call header contained in an RPC record that is
excessively large. The full maximum payload size cannot be
constructed in that case.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs3proc.c