]> git.baikalelectronics.ru Git - kernel.git/commit
openvswitch: Fix IPv6 exthdr handling with ct helpers.
authorJoe Stringer <joestringer@nicira.com>
Mon, 14 Sep 2015 18:14:50 +0000 (11:14 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Sep 2015 22:31:49 +0000 (15:31 -0700)
commit5f75cbfa1ce86dbed520dbbc3c20fa123c7b1583
treee432102079b6cf36d60694424aeddfc5f6398df0
parentc84d6ea31633f3f5f754f600b20175617ecd866c
openvswitch: Fix IPv6 exthdr handling with ct helpers.

Static code analysis reveals the following bug:

        net/openvswitch/conntrack.c:281 ovs_ct_helper()
        warn: unsigned 'protoff' is never less than zero.

This signedness bug breaks error handling for IPv6 extension headers when
using conntrack helpers. Fix the error by using a local signed variable.

Fixes: 4b4669d7e5b8: "openvswitch: Allow attaching helpers to ct
action"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joe Stringer <joestringer@nicira.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/conntrack.c