]> git.baikalelectronics.ru Git - kernel.git/commit
NFC: nci: Bounds check struct nfc_target arrays
authorKees Cook <keescook@chromium.org>
Fri, 2 Dec 2022 21:44:14 +0000 (13:44 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:46 +0000 (11:30 +0100)
commit5f2f072b26e5aaf427ba7074156492ea610d1029
tree783b8814a8deac1716d8ea88d8bf1647f026aeca
parent00cdd4e40d3540bf71a5f2f3b67f698cf32824d4
NFC: nci: Bounds check struct nfc_target arrays

[ Upstream commit 69a726688bdce23d2278878d9c02d21234f1ddfa ]

While running under CONFIG_FORTIFY_SOURCE=y, syzkaller reported:

  memcpy: detected field-spanning write (size 129) of single field "target->sensf_res" at net/nfc/nci/ntf.c:260 (size 18)

This appears to be a legitimate lack of bounds checking in
nci_add_new_protocol(). Add the missing checks.

Reported-by: syzbot+210e196cef4711b65139@syzkaller.appspotmail.com
Link: https://lore.kernel.org/lkml/0000000000001c590f05ee7b3ff4@google.com
Fixes: 368338513d4f ("NFC: Add NCI multiple targets support")
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20221202214410.never.693-kees@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/nfc/nci/ntf.c