]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: atmel-mci: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 8 Nov 2022 12:28:19 +0000 (20:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:11 +0000 (11:41 +0100)
commit5f2ad5ae3bcb231c11177fc931883f212262e3d4
tree78cca7d701ad60f7a470262aa2070f26a094ccb2
parent62f4393c1d755cea8249e96d12aede5f5f9d192a
mmc: atmel-mci: fix return value check of mmc_add_host()

[ Upstream commit 1f4909a18d6a3bfa79bdaacb613e63bba4b49be1 ]

mmc_add_host() may return error, if we ignore its return value,
it will lead two issues:
1. The memory that allocated in mmc_alloc_host() is leaked.
2. In the remove() path, mmc_remove_host() will be called to
   delete device, but it's not added yet, it will lead a kernel
   crash because of null-ptr-deref in device_del().

So fix this by checking the return value and calling mmc_free_host()
in the error path.

Fixes: bb8c85fe87fc ("atmel-mci: Driver for Atmel on-chip MMC controllers")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221108122819.429975-1-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/atmel-mci.c