]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "usb: storage: Add quirk for Samsung Fit flash"
authorsunghwan jung <onenowy@gmail.com>
Tue, 13 Sep 2022 11:49:13 +0000 (20:49 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Sep 2022 13:52:31 +0000 (15:52 +0200)
commit5f02f1a30c2e078911e004ff7073dfa1d336d8f7
treeb73cf4ee6512ac84a905d2154a27da5d04d3c268
parent473db447b26570cd1049e0a3b4a9e0b6c0a38479
Revert "usb: storage: Add quirk for Samsung Fit flash"

This reverts commit 40dceaf5c3f60ade4990cc5d8ead4b5e1b8e8d92,
which fix the timeout issue for "Samsung Fit Flash".

But the commit affects not only "Samsung Fit Flash" but also other usb
storages that use the same controller and causes severe performance
regression.

 # hdparm -t /dev/sda (without the quirk)
 Timing buffered disk reads: 622 MB in  3.01 seconds = 206.66 MB/sec

 # hdparm -t /dev/sda (with the quirk)
 Timing buffered disk reads: 220 MB in  3.00 seconds =  73.32 MB/sec

The commit author mentioned that "Issue was reproduced after device has
bad block", so this quirk should be applied when we have the timeout
issue with a device that has bad blocks.

We revert the commit so that we apply this quirk by adding kernel
paramters using a bootloader or other ways when we really need it,
without the performance regression with devices that don't have the
issue.

Signed-off-by: sunghwan jung <onenowy@gmail.com>
Link: https://lore.kernel.org/r/20220913114913.3073-1-onenowy@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/unusual_devs.h