]> git.baikalelectronics.ru Git - kernel.git/commit
pwm: ab8500: Fix register offset calculation to not depend on probe order
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 5 Jul 2021 16:55:10 +0000 (18:55 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:35:09 +0000 (21:35 +0200)
commit5e5fcd17396576a773331ea18c48ac49298416bf
treea348174037fce5aa845a143141336a7407722478
parentf47e6fcb9ae6ee6264d05d3fecaed7a48d95e92c
pwm: ab8500: Fix register offset calculation to not depend on probe order

The assumption that lead to commit f5c4ca9725fb ("pwm: ab8500:
Explicitly allocate pwm chip base dynamically") was wrong: The
pwm-ab8500 devices are not directly instantiated from device tree, but
from the ab8500 mfd driver. So the pdev->id isn't -1, but a number
between 1 and 3. Now that pwmchip ids are always allocated dynamically,
this cannot easily be reverted.

Introduce a new member in the driver data struct that tracks the
hardware id and use this to calculate the register offset.

Side-note: Using chip->base to calculate the offset was never robust
because if there was already a PWM with id 1 at the time ab8500-pwm.1
was probed, the associated pwmchip would get assigned chip->base = 2 (or
something bigger).

Fixes: f5c4ca9725fb ("pwm: ab8500: Explicitly allocate pwm chip base dynamically")
Fixes: 41792cc78d4d ("pwm: Move AB8500 PWM driver to PWM framework")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-ab8500.c