]> git.baikalelectronics.ru Git - kernel.git/commit
locking/lockdep: Remove the unnecessary trace saving
authorBoqun Feng <boqun.feng@gmail.com>
Fri, 18 Jun 2021 17:01:08 +0000 (01:01 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 22 Jun 2021 14:42:07 +0000 (16:42 +0200)
commit5da091b21fc4354271dad940e783c4e2dc5bc58b
treee716bdd8c65297b0911335f89f765ab96dc2f096
parentd7a0d801d1124793a140ae24cbe6a4e5ec62b3e8
locking/lockdep: Remove the unnecessary trace saving

In print_bad_irq_dependency(), save_trace() is called to set the ->trace
for @prev_root as the current call trace, however @prev_root corresponds
to the the held lock, which may not be acquired in current call trace,
therefore it's wrong to use save_trace() to set ->trace of @prev_root.
Moreover, with our adjustment of printing backwards dependency path, the
->trace of @prev_root is unncessary, so remove it.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210618170110.3699115-3-boqun.feng@gmail.com
kernel/locking/lockdep.c