]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Improve debug Kconfig texts a bit
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 2 Jul 2021 20:17:08 +0000 (22:17 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 6 Jul 2021 08:10:07 +0000 (10:10 +0200)
commit5d22b3fb8591f8515ee9f1cc95c8a664f242846c
treefcaac6c8447dbe6e257dae7e20e0cf22024057f0
parentd38b83476b620bc7b954bafb7f13a9eaf4cd6e84
drm/i915: Improve debug Kconfig texts a bit

We're not consistently recommending these for developers only.

I stumbled over this due to DRM_I915_LOW_LEVEL_TRACEPOINTS, which was
added in

commit cd69238acf8ef8ed9e46927e7849bc6f1d217821
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Tue Feb 21 11:01:42 2017 +0000

    drm/i915/tracepoints: Add request submit and execute tracepoints

to "alleviate the performance impact concerns."

Which is nonsense.

Tvrtko and Joonas pointed out on irc that the real (but undocumented
reason) was stable abi concerns for tracepoints, see

https://lwn.net/Articles/705270/

and the specific change that was blocked around tracepoints:

https://lwn.net/Articles/442113/

Anyway to make it a notch clearer why we have this Kconfig option
consistly add the "Recommended for driver developers only." to it and
all the other debug options we have.

Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210702201708.2075793-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/i915/Kconfig.debug