]> git.baikalelectronics.ru Git - kernel.git/commit
drm/plane-helper: fix uninitialized variable reference
authorAlex Xu (Hello71) <alex_y_xu@yahoo.ca>
Thu, 7 Oct 2021 06:37:06 +0000 (02:37 -0400)
committerSimon Ser <contact@emersion.fr>
Thu, 7 Oct 2021 10:24:44 +0000 (12:24 +0200)
commit5d05e3f5897ce6a553044565ef97687d98290135
tree92f1548965dad9f0b9ed76ab9c443d3cc0fbbb93
parente071e66da8a36d3d39ee93f69ce46efca0016af3
drm/plane-helper: fix uninitialized variable reference

drivers/gpu/drm/drm_plane_helper.c: In function 'drm_primary_helper_update':
drivers/gpu/drm/drm_plane_helper.c:113:32: error: 'visible' is used uninitialized [-Werror=uninitialized]
  113 |         struct drm_plane_state plane_state = {
      |                                ^~~~~~~~~~~
drivers/gpu/drm/drm_plane_helper.c:178:14: note: 'visible' was declared here
  178 |         bool visible;
      |              ^~~~~~~
cc1: all warnings being treated as errors

visible is an output, not an input. in practice this use might turn out
OK but it's still UB.

Fixes: 6e8229864a2b ("drm/plane-helper: Add drm_plane_helper_check_state()")
Reviewed-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Signed-off-by: Simon Ser <contact@emersion.fr>
Link: https://patchwork.freedesktop.org/patch/msgid/20211007063706.305984-1-alex_y_xu@yahoo.ca
drivers/gpu/drm/drm_plane_helper.c