]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: Always build secure_cntvoff.S on ARM V7 to fix shmobile !SMP build
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 6 Jun 2018 09:25:16 +0000 (11:25 +0200)
committerOlof Johansson <olof@lixom.net>
Sun, 24 Jun 2018 01:26:48 +0000 (18:26 -0700)
commit5cf039bb9e776dffb2f4bf658b5a2a90a3ddcc0f
tree665898e4c53921dc9ad4cda35461f4b445cc1795
parent3b6067c6573ceccf3a866b4aa8fc9a958670e4b9
ARM: Always build secure_cntvoff.S on ARM V7 to fix shmobile !SMP build

If CONFIG_SMP=n, building a kernel for R-Car Gen2 fails with:

    arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init':
    setup-rcar-gen2.c:(.init.text+0x30): undefined reference to `secure_cntvoff_init'

Indeed, on R-Car Gen2 SoCs, secure_cntvoff_init() is not only needed for
secondary CPUs, but also for the boot CPU.  This is most visible on SoCs
with Cortex A7 cores (e.g. R-Car E2, cfr. commit ef9e3b64c5ccacc8 ("ARM:
shmobile: rcar-gen2: Add CA7 arch_timer initialization for r8a7794")),
but Cortex A15 is affected, too.

Fix this by always providing secure_cntvoff_init() when building for ARM
V7.

Reported-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d22a1d718daba816 ("ARM: smp: Add initialization of CNTVOFF")
Fixes: fed8f36df7fc835b ("ARM: shmobile: Convert file to use cntvoff")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Olof Johansson <olof@lixom.net>
arch/arm/common/Makefile