]> git.baikalelectronics.ru Git - kernel.git/commit
PCI/MSI: Fix memory leak in free_msi_irqs()
authorAlexei Starovoitov <ast@plumgrid.com>
Wed, 4 Jun 2014 22:49:50 +0000 (15:49 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 11 Jun 2014 17:13:19 +0000 (11:13 -0600)
commit5cbd6a7ce247b5914c94bcbc1773b416f287e8b2
tree1c42a0508a55e736faa6a7e04731a674caa02099
parent87bb660048b3b34fb1c4ee36d3b8bedf6f8a77a1
PCI/MSI: Fix memory leak in free_msi_irqs()

free_msi_irqs() is leaking memory, since list_for_each_entry(entry,
&dev->msi_list, list) {...} is never executed, because dev->msi_list is
made empty by the loop just above this one.

Fix it by relying on zero termination of attribute array like
populate_msi_sysfs() does.

Fixes: 8407b4418990 ("PCI/MSI: Export MSI mode using attributes, not kobjects")
Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: stable@vger.kernel.org # v3.14+
drivers/pci/msi.c