]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "mmc: tmio: fix reset operation"
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 20 Aug 2020 13:25:34 +0000 (15:25 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 7 Sep 2020 07:11:30 +0000 (09:11 +0200)
commit5ca3de113aa3e12e9070ee2285160b93374991c2
treefb3f258e04677cfb01696f041a36f88a89cfac8c
parentf68f791e13e1ded5063e63ffe21d2f3a011e3cc9
Revert "mmc: tmio: fix reset operation"

This reverts commit 450cce64bf5edd5a656b497012196c7e13290a51. It did fix
the issue, but was building on top of already wrong assumptions. The
driver missed that 'hw_reset' was only for resetting remote HW (card)
and not for the IP core. Since we fixed that in a previous patch, we can
now remove this patch to make it clear that 'reset' is for resetting the
IP core only. Also, cancelling DMA will only be called when actually
needed again. It will also allow for further cleanups and better
readability. Note that in addition to the revert, the call in
'tmio_mmc_execute_tuning' will be converted, too, to maintain the
current behaviour.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20200820132538.24758-3-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_core.c