]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: Align compat attrlist_by_handle with native implementation.
authorNick Bowler <nbowler@draconx.ca>
Mon, 17 Dec 2018 17:35:27 +0000 (09:35 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Tue, 18 Dec 2018 18:55:20 +0000 (10:55 -0800)
commit5c3c0573d3680bbea199dbc0ce480a1331725e05
treeab305c4d8420813530e61b568b142dcc0fcf68f1
parent2f63e10ac67404726c9e763880274c082e815f1c
xfs: Align compat attrlist_by_handle with native implementation.

While inspecting the ioctl implementations, I noticed that the compat
implementation of XFS_IOC_ATTRLIST_BY_HANDLE does not do exactly the
same thing as the native implementation.  Specifically, the "cursor"
does not appear to be written out to userspace on the compat path,
like it is on the native path.

This adjusts the compat implementation to copy out the cursor just
like the native implementation does.  The attrlist cursor does not
require any special compat handling.  This fixes xfstests xfs/269
on both IA-32 and x32 userspace, when running on an amd64 kernel.

Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Fixes: c6bd119c1c0d1 ("xfs: in _attrlist_by_handle, copy the cursor back to userspace")
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_ioctl32.c