]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: tracepoints: Fix wrong parameter order for qgroup events
authorQu Wenruo <wqu@suse.com>
Thu, 17 Oct 2019 02:38:36 +0000 (10:38 +0800)
committerDavid Sterba <dsterba@suse.com>
Thu, 17 Oct 2019 12:09:31 +0000 (14:09 +0200)
commit5c0afed939770dd589c5ea61bce45ab3d31b8eb4
treed6007d094ba3fc3e6051abfc7355c181bd0c8956
parent905d3ca69e5552db677e69d39ac9ab8dbe2d00fc
btrfs: tracepoints: Fix wrong parameter order for qgroup events

[BUG]
For btrfs:qgroup_meta_reserve event, the trace event can output garbage:

  qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7: refroot=5(FS_TREE) type=DATA diff=2

The diff should always be alinged to sector size (4k), so there is
definitely something wrong.

[CAUSE]
For the wrong @diff, it's caused by wrong parameter order.
The correct parameters are:

  struct btrfs_root, s64 diff, int type.

However the parameters used are:

  struct btrfs_root, int type, s64 diff.

Fixes: ed0c8d2d341a ("btrfs: qgroup: Update trace events for metadata reservation")
CC: stable@vger.kernel.org # 4.19+
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c