]> git.baikalelectronics.ru Git - kernel.git/commit
nvme: define compat_ioctl again to unbreak 32-bit userspace.
authorNick Bowler <nbowler@draconx.ca>
Thu, 21 Jul 2022 03:57:35 +0000 (23:57 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:00 +0000 (14:24 +0200)
commit5bf959b8cf2e98cf5c6ff1377d602147bafc6e0c
treea3868eb17ef4a64b9f6628a86c828245b8954d20
parent13abafeee975f3bf860fd50af50fb71446377b7d
nvme: define compat_ioctl again to unbreak 32-bit userspace.

[ Upstream commit ee026adfc8dd41ef48a89c66dda6f67e27dc6742 ]

Commit b518fe63526b ("nvme: simplify the compat ioctl handling") removed
the initialization of compat_ioctl from the nvme block_device_operations
structures.

Presumably the expectation was that 32-bit ioctls would be directed
through the regular handler but this is not the case: failing to assign
.compat_ioctl actually means that the compat case is disabled entirely,
and any attempt to submit nvme ioctls from 32-bit userspace fails
outright with -ENOTTY.

For example:

  % smartctl -x /dev/nvme0n1
  [...]
  Read NVMe Identify Controller failed: NVME_IOCTL_ADMIN_CMD: Inappropriate ioctl for device

The blkdev_compat_ptr_ioctl helper can be used to direct compat calls
through the main ioctl handler and makes things work again.

Fixes: b518fe63526b ("nvme: simplify the compat ioctl handling")
Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Reviewed-by: Guixin Liu <kanie@linux.alibaba.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/core.c
drivers/nvme/host/multipath.c