]> git.baikalelectronics.ru Git - kernel.git/commit
io_uring: avoid whole io_wq_work copy for requests completed inline
authorXiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Wed, 10 Jun 2020 11:41:19 +0000 (19:41 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 10 Jun 2020 23:58:46 +0000 (17:58 -0600)
commit5bb74e32cf5b85f33ac59714ba52402abf3cb003
tree14b4686517cdc4f0a7fa4ef2faf6b4658b198572
parent90fc1169b7d11457fe03c483fd1f4ef74ac5a622
io_uring: avoid whole io_wq_work copy for requests completed inline

If requests can be submitted and completed inline, we don't need to
initialize whole io_wq_work in io_init_req(), which is an expensive
operation, add a new 'REQ_F_WORK_INITIALIZED' to determine whether
io_wq_work is initialized and add a helper io_req_init_async(), users
must call io_req_init_async() for the first time touching any members
of io_wq_work.

I use /dev/nullb0 to evaluate performance improvement in my physical
machine:
  modprobe null_blk nr_devices=1 completion_nsec=0
  sudo taskset -c 60 fio  -name=fiotest -filename=/dev/nullb0 -iodepth=128
  -thread -rw=read -ioengine=io_uring -direct=1 -bs=4k -size=100G -numjobs=1
  -time_based -runtime=120

before this patch:
Run status group 0 (all jobs):
   READ: bw=724MiB/s (759MB/s), 724MiB/s-724MiB/s (759MB/s-759MB/s),
   io=84.8GiB (91.1GB), run=120001-120001msec

With this patch:
Run status group 0 (all jobs):
   READ: bw=761MiB/s (798MB/s), 761MiB/s-761MiB/s (798MB/s-798MB/s),
   io=89.2GiB (95.8GB), run=120001-120001msec

About 5% improvement.

Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io-wq.h
fs/io_uring.c