]> git.baikalelectronics.ru Git - kernel.git/commit
spi: mediatek: Fix fifo transfer
authorGuenter Roeck <linux@roeck-us.net>
Mon, 2 Aug 2021 03:00:23 +0000 (20:00 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 2 Aug 2021 11:20:20 +0000 (12:20 +0100)
commit5b618318a2d51c487c399dfe9151762804716f46
tree49d747e713ae6d1526c406749ed2d14341f0cea1
parente814f80f694453eae66b5c49eebb8ab68fc171c9
spi: mediatek: Fix fifo transfer

Commit 20bad50ddffc ("spi: mediatek: fix fifo rx mode") claims that
fifo RX mode was never handled, and adds the presumably missing code
to the FIFO transfer function. However, the claim that receive data
was not handled is incorrect. It was handled as part of interrupt
handling after the transfer was complete. The code added with the above
mentioned commit reads data from the receive FIFO before the transfer
is started, which is wrong. This results in an actual transfer error
on a Hayato Chromebook.

Remove the code trying to handle receive data before the transfer is
started to fix the problem.

Fixes: 20bad50ddffc ("spi: mediatek: fix fifo rx mode")
Cc: Peter Hess <peter.hess@ph-home.de>
Cc: Frank Wunderlich <frank-w@public-files.de>
Cc: Tzung-Bi Shih <tzungbi@google.com>
Cc: Hsin-Yi Wang <hsinyi@google.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Hsin-Yi Wang <hsinyi@google.com>
Tested-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20210802030023.1748777-1-linux@roeck-us.net
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mt65xx.c