]> git.baikalelectronics.ru Git - kernel.git/commit
gfs2: No short reads or writes upon glock contention
authorAndreas Gruenbacher <agruenba@redhat.com>
Thu, 28 Apr 2022 12:51:33 +0000 (14:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 May 2022 07:14:39 +0000 (09:14 +0200)
commit5b3423a142ee53a48e7ee61f2b6278a95f0dcbfb
tree153d19b9c5761497dae74a9dc2a500d628440744
parent67fba48c31cbeb9527e229cddd4f85698cda7dd4
gfs2: No short reads or writes upon glock contention

[ Upstream commit 5d328f8bc513e7eb4ef5c64c7394b918a2e08e82 ]

Commit 9d0ff4feb1a7 ("gfs2: Fix mmap + page fault deadlocks for buffered
I/O") changed gfs2_file_read_iter() and gfs2_file_buffered_write() to
allow dropping the inode glock while faulting in user buffers.  When the
lock was dropped, a short result was returned to indicate that the
operation was interrupted.

As pointed out by Linus (see the link below), this behavior is broken
and the operations should always re-acquire the inode glock and resume
the operation instead.

Link: https://lore.kernel.org/lkml/CAHk-=whaz-g_nOOoo8RRiWNjnv2R+h6_xk2F1J4TuSRxk1MtLw@mail.gmail.com/
Fixes: 9d0ff4feb1a7 ("gfs2: Fix mmap + page fault deadlocks for buffered I/O")
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/gfs2/file.c