]> git.baikalelectronics.ru Git - kernel.git/commit
i40e, xsk: clear the status bits for the next_to_use descriptor
authorBjörn Töpel <bjorn.topel@intel.com>
Fri, 11 Dec 2020 14:57:12 +0000 (15:57 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 16 Dec 2020 18:51:07 +0000 (10:51 -0800)
commit5a622dfede5b22835b78b84f5627b3ee3354cc1a
tree371bc1fdaaeb6fe6b187afc334ac954221551a38
parent58628977e2f4ad5e84ac65470d033e7433d5bcc9
i40e, xsk: clear the status bits for the next_to_use descriptor

On the Rx side, the next_to_use index points to the next item in the
HW ring to be refilled/allocated, and next_to_clean points to the next
item to potentially be processed.

When the HW Rx ring is fully refilled, i.e. no packets has been
processed, the next_to_use will be next_to_clean - 1. When the ring is
fully processed next_to_clean will be equal to next_to_use. The latter
case is where a bug is triggered.

If the next_to_use bits are not cleared, and the "fully processed"
state is entered, a stale descriptor can be processed.

The skb-path correctly clear the status bit for the next_to_use
descriptor, but the AF_XDP zero-copy path did not do that.

This change adds the status bits clearing of the next_to_use
descriptor.

Fixes: 8afce9d352b1 ("i40e, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/i40e/i40e_xsk.c